From 8bde60fc8d8984eb5a22eff998825403fbcef6db Mon Sep 17 00:00:00 2001 From: Nurmuhammet Allanov Date: Wed, 12 Mar 2025 23:46:17 +0500 Subject: [PATCH] stan errors --- app/Http/Controllers/PasswordChangeController.php | 2 +- app/Models/Order/Card/Requisite/CardRequisite.php | 6 ++++++ app/Models/Order/Loan/LoanOrder.php | 10 ++++++++++ app/Models/Order/Loan/LoanPaidOffLetterOrder.php | 4 ++++ app/Models/User.php | 8 ++++++++ app/Modules/ApiAuth/Requests/AuthLoginRequest.php | 2 +- .../ApiAuth/Requests/AuthRegisterRequest.php | 2 +- app/Modules/ApiAuth/Requests/AuthVerifyRequest.php | 2 +- .../Controllers/BaseAppEnumController.php | 7 +++++++ .../Branch/Controllers/BranchController.php | 3 ++- .../Repositories/DateHelperRepository.php | 12 ++++++++++++ .../LoanOrder/Controllers/LoanOrderController.php | 14 ++++++++------ .../Controllers/Requests/LoanOrderStoreRequest.php | 2 +- .../LoanOrder/Models/LoanOrderRequiredDocs.php | 2 ++ .../LoanOrderRequiredDocsRepository.php | 5 ++++- .../LoanType/Controllers/LoanTypeController.php | 3 ++- .../Province/Controllers/ProvinceController.php | 3 ++- .../SberPaymentOrder/Models/SberPaymentOrder.php | 4 ++++ 18 files changed, 76 insertions(+), 15 deletions(-) diff --git a/app/Http/Controllers/PasswordChangeController.php b/app/Http/Controllers/PasswordChangeController.php index bb14a33..17f1034 100644 --- a/app/Http/Controllers/PasswordChangeController.php +++ b/app/Http/Controllers/PasswordChangeController.php @@ -20,7 +20,7 @@ class PasswordChangeController extends Controller /** * Update password */ - public function update(Request $request): \Illuminate\Routing\Redirector|\Illuminate\Http\RedirectResponse + public function update(Request $request): \Illuminate\Routing\Redirector|\Illuminate\Http\RedirectResponse { $request->validate([ 'password' => ['string', 'min:8', 'confirmed'], diff --git a/app/Models/Order/Card/Requisite/CardRequisite.php b/app/Models/Order/Card/Requisite/CardRequisite.php index 10ad8ca..4f2406f 100644 --- a/app/Models/Order/Card/Requisite/CardRequisite.php +++ b/app/Models/Order/Card/Requisite/CardRequisite.php @@ -54,6 +54,8 @@ class CardRequisite extends Model /** * User + * + * @return BelongsTo */ public function user(): BelongsTo { @@ -62,6 +64,8 @@ class CardRequisite extends Model /** * Card type + * + * @return BelongsTo */ public function cardType(): BelongsTo { @@ -70,6 +74,8 @@ class CardRequisite extends Model /** * Branch + * + * @return BelongsTo */ public function branch(): BelongsTo { diff --git a/app/Models/Order/Loan/LoanOrder.php b/app/Models/Order/Loan/LoanOrder.php index 8149718..b93ab63 100644 --- a/app/Models/Order/Loan/LoanOrder.php +++ b/app/Models/Order/Loan/LoanOrder.php @@ -150,6 +150,8 @@ class LoanOrder extends Model /** * Loan type + * + * @return BelongsTo */ public function loanType(): BelongsTo { @@ -158,6 +160,8 @@ class LoanOrder extends Model /** * Branch + * + * @return BelongsTo */ public function branch(): BelongsTo { @@ -166,6 +170,8 @@ class LoanOrder extends Model /** * Work province + * + * @return BelongsTo */ public function workProvince(): BelongsTo { @@ -174,6 +180,8 @@ class LoanOrder extends Model /** * User (who created order) + * + * @return BelongsTo */ public function user(): BelongsTo { @@ -182,6 +190,8 @@ class LoanOrder extends Model /** * Required docs + * + * @return BelongsTo */ public function requiredDocs(): BelongsTo { diff --git a/app/Models/Order/Loan/LoanPaidOffLetterOrder.php b/app/Models/Order/Loan/LoanPaidOffLetterOrder.php index c021f39..5f84424 100644 --- a/app/Models/Order/Loan/LoanPaidOffLetterOrder.php +++ b/app/Models/Order/Loan/LoanPaidOffLetterOrder.php @@ -52,6 +52,8 @@ class LoanPaidOffLetterOrder extends Model /** * User + * + * @return BelongsTo */ public function user(): BelongsTo { @@ -60,6 +62,8 @@ class LoanPaidOffLetterOrder extends Model /** * Branch + * + * @return BelongsTo */ public function branch(): BelongsTo { diff --git a/app/Models/User.php b/app/Models/User.php index 74eec42..5e0b331 100644 --- a/app/Models/User.php +++ b/app/Models/User.php @@ -75,6 +75,8 @@ class User extends Authenticatable /** * Branches associated with user + * + * @return BelongsToMany */ public function branches(): BelongsToMany { @@ -83,6 +85,8 @@ class User extends Authenticatable /** * Loan orders user created + * + * @return HasMany */ public function loanOrders(): HasMany { @@ -91,6 +95,8 @@ class User extends Authenticatable /** * Card orders user created + * + * @return HasMany */ public function cardOrders(): HasMany { @@ -99,6 +105,8 @@ class User extends Authenticatable /** * Alerts + * + * @return HasMany */ public function alerts(): HasMany { diff --git a/app/Modules/ApiAuth/Requests/AuthLoginRequest.php b/app/Modules/ApiAuth/Requests/AuthLoginRequest.php index 233f904..c32905c 100644 --- a/app/Modules/ApiAuth/Requests/AuthLoginRequest.php +++ b/app/Modules/ApiAuth/Requests/AuthLoginRequest.php @@ -9,7 +9,7 @@ class AuthLoginRequest extends FormRequest /** * Get the validation rules that apply to the request. * - * @return array + * @return array|string> */ public function rules(): array { diff --git a/app/Modules/ApiAuth/Requests/AuthRegisterRequest.php b/app/Modules/ApiAuth/Requests/AuthRegisterRequest.php index 20a3f56..45d1b09 100644 --- a/app/Modules/ApiAuth/Requests/AuthRegisterRequest.php +++ b/app/Modules/ApiAuth/Requests/AuthRegisterRequest.php @@ -9,7 +9,7 @@ class AuthRegisterRequest extends FormRequest /** * Get the validation rules that apply to the request. * - * @return array + * @return array|string> */ public function rules(): array { diff --git a/app/Modules/ApiAuth/Requests/AuthVerifyRequest.php b/app/Modules/ApiAuth/Requests/AuthVerifyRequest.php index f43bde1..407dfa0 100644 --- a/app/Modules/ApiAuth/Requests/AuthVerifyRequest.php +++ b/app/Modules/ApiAuth/Requests/AuthVerifyRequest.php @@ -10,7 +10,7 @@ class AuthVerifyRequest extends FormRequest /** * Get the validation rules that apply to the request. * - * @return array + * @return array|string> */ public function rules(): array { diff --git a/app/Modules/BaseAppEnum/Controllers/BaseAppEnumController.php b/app/Modules/BaseAppEnum/Controllers/BaseAppEnumController.php index 4ca49fe..30b9e33 100644 --- a/app/Modules/BaseAppEnum/Controllers/BaseAppEnumController.php +++ b/app/Modules/BaseAppEnum/Controllers/BaseAppEnumController.php @@ -13,6 +13,8 @@ class BaseAppEnumController extends Controller { /** * Base app enums + * + * @return array */ public function index(): array { @@ -25,6 +27,11 @@ class BaseAppEnumController extends Controller ]; } + /** + * Education values + * + * @return array + */ public function educationValues(): array { return [ diff --git a/app/Modules/Branch/Controllers/BranchController.php b/app/Modules/Branch/Controllers/BranchController.php index 29c3627..5e89677 100644 --- a/app/Modules/Branch/Controllers/BranchController.php +++ b/app/Modules/Branch/Controllers/BranchController.php @@ -4,6 +4,7 @@ namespace App\Modules\Branch\Controllers; use App\Http\Controllers\Controller; use App\Models\Branch\Branch; +use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; class BranchController extends Controller @@ -11,7 +12,7 @@ class BranchController extends Controller /** * LIST branches */ - public function index(Request $request) + public function index(Request $request): JsonResponse { $request->validate([ 'groupBy' => ['nullable', 'string', 'in:region'], diff --git a/app/Modules/DateHelper/Repositories/DateHelperRepository.php b/app/Modules/DateHelper/Repositories/DateHelperRepository.php index a4fffb1..d5d8863 100644 --- a/app/Modules/DateHelper/Repositories/DateHelperRepository.php +++ b/app/Modules/DateHelper/Repositories/DateHelperRepository.php @@ -4,6 +4,11 @@ namespace App\Modules\DateHelper\Repositories; class DateHelperRepository { + /** + * Month as number + * + * @return array + */ public static function monthsAsNumber(): array { $month = []; @@ -15,6 +20,13 @@ class DateHelperRepository return $month; } + /** + * Years until + * + * @param int|int $max + * + * @return array + */ public static function yearsUntil(int $max = 50): array { $years = []; diff --git a/app/Modules/LoanOrder/Controllers/LoanOrderController.php b/app/Modules/LoanOrder/Controllers/LoanOrderController.php index 84a896d..04efd0d 100644 --- a/app/Modules/LoanOrder/Controllers/LoanOrderController.php +++ b/app/Modules/LoanOrder/Controllers/LoanOrderController.php @@ -32,7 +32,7 @@ class LoanOrderController extends Controller /** * SAVE* Loan order. */ - public function store(LoanOrderStoreRequest $request) + public function store(LoanOrderStoreRequest $request): JsonResponse { Log::channel('form_logs')->info('loan-order-store-request', $request->all()); @@ -67,6 +67,8 @@ class LoanOrderController extends Controller /** * Upload files + * + * @return array */ public function uploadedFiles(Request $request): array { @@ -81,10 +83,10 @@ class LoanOrderController extends Controller /** * SHOW* Loan order */ - public function show(LoanOrder $loanOrder) + public function show(LoanOrder $loanOrder): JsonResponse { if ($loanOrder->user_id != auth()->id()) { - return response(status: 403); + return response()->json(status: 403); } return response()->json(new LoanOrderShowResource($loanOrder)); @@ -93,7 +95,7 @@ class LoanOrderController extends Controller /** * Update the specified resource in storage. */ - public function update(Request $request) + public function update(Request $request): void { // } @@ -101,10 +103,10 @@ class LoanOrderController extends Controller /** * DELETE* loan order resource */ - public function destroy(LoanOrder $loanOrder) + public function destroy(LoanOrder $loanOrder): JsonResponse { if ($loanOrder->user_id === auth()->id()) { - return response(status: 403); + return response()->json(status: 403); } $loanOrder->delete(); diff --git a/app/Modules/LoanOrder/Controllers/Requests/LoanOrderStoreRequest.php b/app/Modules/LoanOrder/Controllers/Requests/LoanOrderStoreRequest.php index fba1747..40abe7a 100644 --- a/app/Modules/LoanOrder/Controllers/Requests/LoanOrderStoreRequest.php +++ b/app/Modules/LoanOrder/Controllers/Requests/LoanOrderStoreRequest.php @@ -14,7 +14,7 @@ class LoanOrderStoreRequest extends FormRequest /** * Get the validation rules that apply to the request. * - * @return array + * @return array|string> */ public function rules(): array { diff --git a/app/Modules/LoanOrder/Models/LoanOrderRequiredDocs.php b/app/Modules/LoanOrder/Models/LoanOrderRequiredDocs.php index 712f181..6bf8bfd 100644 --- a/app/Modules/LoanOrder/Models/LoanOrderRequiredDocs.php +++ b/app/Modules/LoanOrder/Models/LoanOrderRequiredDocs.php @@ -28,6 +28,8 @@ class LoanOrderRequiredDocs extends Model /** * Loan orders + * + * @return HasMany */ public function loanOrders(): HasMany { diff --git a/app/Modules/LoanOrder/Repositories/LoanOrderRequiredDocsRepository.php b/app/Modules/LoanOrder/Repositories/LoanOrderRequiredDocsRepository.php index 438c091..023698e 100644 --- a/app/Modules/LoanOrder/Repositories/LoanOrderRequiredDocsRepository.php +++ b/app/Modules/LoanOrder/Repositories/LoanOrderRequiredDocsRepository.php @@ -3,6 +3,7 @@ namespace App\Modules\LoanOrder\Repositories; use App\Modules\LoanOrder\Models\LoanOrderRequiredDocs; +use Illuminate\Database\Eloquent\Model; use Illuminate\Support\Collection; class LoanOrderRequiredDocsRepository @@ -12,13 +13,15 @@ class LoanOrderRequiredDocsRepository * * @param int $id */ - public static function find(int $id) + public static function find(int $id): ?Model { return LoanOrderRequiredDocs::find($id); } /** * Values + * + * @return Collection|array */ public static function values(): Collection|array { diff --git a/app/Modules/LoanType/Controllers/LoanTypeController.php b/app/Modules/LoanType/Controllers/LoanTypeController.php index 795dfd7..6655cd5 100644 --- a/app/Modules/LoanType/Controllers/LoanTypeController.php +++ b/app/Modules/LoanType/Controllers/LoanTypeController.php @@ -4,13 +4,14 @@ namespace App\Modules\LoanType\Controllers; use App\Http\Controllers\Controller; use App\Models\Order\Loan\LoanType; +use Illuminate\Http\JsonResponse; class LoanTypeController extends Controller { /** * Loan types (for loan-orders) */ - public function index() + public function index(): JsonResponse { return response()->json(LoanType::get(['id', 'name'])->map(fn ($loanOrder) => [ 'id' => $loanOrder->id, diff --git a/app/Modules/Province/Controllers/ProvinceController.php b/app/Modules/Province/Controllers/ProvinceController.php index 402782d..c35b514 100644 --- a/app/Modules/Province/Controllers/ProvinceController.php +++ b/app/Modules/Province/Controllers/ProvinceController.php @@ -4,6 +4,7 @@ namespace App\Modules\Province\Controllers; use App\Http\Controllers\Controller; use App\Models\System\Location\Province; +use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; class ProvinceController extends Controller @@ -11,7 +12,7 @@ class ProvinceController extends Controller /** * LIST provinces (etraplar) */ - public function index(Request $request) + public function index(Request $request): JsonResponse { $request->validate([ 'groupBy' => ['nullable', 'string', 'in:region'], diff --git a/app/Modules/SberPaymentOrder/Models/SberPaymentOrder.php b/app/Modules/SberPaymentOrder/Models/SberPaymentOrder.php index bac60d7..9e3adb3 100644 --- a/app/Modules/SberPaymentOrder/Models/SberPaymentOrder.php +++ b/app/Modules/SberPaymentOrder/Models/SberPaymentOrder.php @@ -84,6 +84,8 @@ class SberPaymentOrder extends Model implements HasMedia /** * Branch + * + * @return BelongsTo */ public function branch(): BelongsTo { @@ -92,6 +94,8 @@ class SberPaymentOrder extends Model implements HasMedia /** * Required files + * + * @return array> */ public static function reciverFiles(): array {